add a handful of examples for the various charts #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add an example for each product using sqlite (with NOT NFS), and an example of Connect using a sidecar sssd so that a dedicated Connect build is not required.
dbkegley
reviewed
Jan 24, 2023
Comment on lines
+6
to
+41
| volumes: | ||
| - name: sssd-emptydir | ||
| emptyDir: {} | ||
| - name: sssd-config | ||
| configMap: | ||
| name: sssd-config | ||
| defaultMode: 0600 | ||
| - name: pam-config | ||
| configMap: | ||
| name: pam-config | ||
| defaultMode: 0755 | ||
| volumeMounts: | ||
| - name: sssd-emptydir | ||
| mountPath: /var/lib/sss | ||
| - name: pam-config | ||
| mountPath: /etc/pam.d/common-account | ||
| subPath: common-account | ||
| - name: pam-config | ||
| mountPath: /etc/pam.d/common-session | ||
| subPath: common-session | ||
| - name: pam-config | ||
| mountPath: /etc/pam.d/common-auth | ||
| subPath: common-auth | ||
| - name: pam-config | ||
| mountPath: /etc/pam.d/common-password | ||
| subPath: common-password | ||
| sidecar: | ||
| - name: sssd | ||
| image: "some-sssd-image" | ||
| imagePullPolicy: "IfNotPresent" | ||
| securityContext: {} | ||
| volumeMounts: | ||
| - name: sssd-emptydir | ||
| mountPath: /var/lib/sss | ||
| - name: sssd-config | ||
| mountPath: /etc/sssd/ |
There was a problem hiding this comment.
We might be able to use this pattern to support runAsCurrent user with off-host execution. I don't think it would require any changes to Connect since we already assume uid/gid/passwd consistency between Connect and the content Pod.
There was a problem hiding this comment.
😮 That's pretty cool!
There was a problem hiding this comment.
@aronatkins pointed out that rsandbox/PAM password forwarding might pose a problem here, but it's worth a spike to see how far this gets us and if there are any other limitations.
colearendt
requested review from
aronatkins,
christierney and
zackverham
as code owners
dbkegley
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add an example for each product using sqlite (with NOT NFS), and an example of Connect using a sidecar sssd so that a dedicated Connect build is not required.
We should really test that these examples work before we add them to the repo