Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to 2.1.0 and add full sync #214

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

timelyportfolio
Copy link
Contributor

@timelyportfolio timelyportfolio commented Sep 25, 2018

(WIP) This pull attempts to

  1. Upgrade to dygraphs 2.1.0
  2. Add y-axis zoom sync and highlight/tooltip sync

Issues

I'd very much appreciate help with this one if anyone out there is willing.

I have not been able to run a full test suite to insure all functionality remains with the newest version. This breaking change "Dropped old-style per-axis/per-series options." concerns me, so I plan to start here.

If you have challenging or non-typical examples and use cases, I would love if you could test these with devtools::install_github("timelyportfolio/dygraphs_htmlwidget).

@przmv przmv added the WIP label Sep 28, 2018
@przmv
Copy link
Collaborator

przmv commented Sep 28, 2018

Awesome! @timelyportfolio please let me know if you need my help with anything!

@przmv
Copy link
Collaborator

przmv commented Apr 8, 2019

Hey @timelyportfolio ! How's it going? Do you need any help with this PR?

@seanlsc
Copy link

seanlsc commented Sep 25, 2023

Hello! @timelyportfolio , I know this is probably gonna be a long shot, but this (the synchronization feature) would be a great help. Is there anything that can be done to get this PR approved? I understand it's been a couple of years since you've opened it; I'll be keen to help out in any way I can, thanks!

@timelyportfolio
Copy link
Contributor Author

Hi @seanlsc thanks for the comment indicating interest. I unfortunately am not sure of the intentions and plans for dygraphs going forward. I guess we can see if there are any responses that might help us understand potential of merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants