(Trade) Arrows with Optional Annotations #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjallaire
reviewed
Feb 28, 2017
| }) | ||
|
|
||
| pluginName <- "Arrow" | ||
| if (dyHasPlugin(dygraph, pluginName)) { |
There was a problem hiding this comment.
This behavior could just be made part of dyPlugin (i.e. if an a plugin name that already exists in the dygraph is added then we append rather than overwrite options). Would there be any downsides to this?
There was a problem hiding this comment.
Makes sense. I'm going to make a separate pull request introducing changes in dyPlugin.
|
I think this looks very cool and seems extremely useful! |
Closed
przmv
changed the title
|
I've made some significant improvements to this plugin. Now it's ready to be released. The updated version can be reached at http://work.severus.io/dygraphs/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating this pull request to gather some feedback on (Trade) Arrows with Optional Annotations feature I'm currently working on.
The output of the current implementation is available here: http://work.severus.io/dygraphs/
@jjallaire @danielkrizian what do you think of it?