-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh tables #665
Merged
Merged
Refresh tables #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
…e tables In unexpanded cards (where we know the card can expand) shrink the table and hide the chrome
Uses more BS sass vars and cleans up CSS variables
gadenbuie
force-pushed
the
refresh/tables
branch
from
July 12, 2023 14:34
916717c
to
d1845c2
Compare
cpsievert
reviewed
Jul 12, 2023
cpsievert
reviewed
Jul 12, 2023
cpsievert
reviewed
Jul 12, 2023
cpsievert
reviewed
Jul 12, 2023
cpsievert
reviewed
Jul 13, 2023
cpsievert
reviewed
Jul 13, 2023
cpsievert
reviewed
Jul 13, 2023
Let's create an issue about making this CSS class more discoverable. One idea we discussed was having something like card(
card_body_table(DT::datatable())
) Or maybe |
gadenbuie
commented
Jul 14, 2023
cpsievert
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets a few default styles for tables and DataTables:
This PR is supported by
Screenshots
Edit: these screenshots capture the look-and-feel, but some details have changed slightly in the final version of the PR (e.g. striping is on even rows).
Full DT table styles
DT table in a card
When a DT table is used in a card that can expand to full screen, it would be useful to hide the table chrome (search, pagination, etc) and just show the table. The least jarring behavior would be to opt into this, so I've implemented it as a card class, e.g.
card(class = "bslib-card-table-sm", ...)
.Docs: We'll want to document this somewhere, but I'm not sure where that place would be. (We can also wait until the full theme is complete.)
DT table in a full-screen card
DT table in a small screen width
Notice header and footer are centered and the main table container (with overflow) scrolls horizontally.