-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add input_switch() #483
Add input_switch() #483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few small comments and suggestions below.
I wonder if we should include arguments for disabled
and reverse
(to disable the input and to reverse the order of the label
and input
). I certainly see a lot of utility for disabled
, but I think we'd also want to allow update_switch()
to disable the input, which would require us to write some swtich-specific JS in bslib or to update the checkbox input binding in shiny. (I lean toward a bslib-specific approach.)
I'd be happy to pick up this PR and add both arguments.
@cpsievert and I discussed in person: this PR will focus on feature parity with Shiny for Python and we'll tackle the above ideas in a future PR |
@cpsievert I applied my suggestions and added a small example app. We could suggest a similar app for Python. |
Let's add a NEWS item then merge away! |
Co-authored-by: Garrick Aden-Buie <[email protected]>
No description provided.