-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Hungarian language @aref #672
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the recent PR #1120 (aiming to fix #1114), it's possible to customize figure labels via a function provided by users. I don't know anything about Hungarian, but I guess at least it should be possible to generate a label like az 1. ábra
now for non-LaTeX output. If that's the case, we don't need to embed the label-generating logic for a particular language inside this package.
For LaTeX output, perhaps we just need a config option for users to specify which LaTeX command they'd like to convert \@ref()
to (the default would still be \ref{}
). Again, I know nothing about \aref{}
, so my naive question is, could redefining \ref
to \aref
solve the problem?
Thanks!
Thank you! Unfortunately this redefinition wouldn't really solve the problem, as we might need |
@tamas-ferenci Thanks for the explanation! We'll think more about it. |
Dear @yihui , I was just wondering if there are any updates on this issue. Thank you very much! |
Sorry, there aren't, but I'm okay with merging this PR (the Git conflicts need to be resolved first). |
That would be great, if you could do it, thank you in advance! |
As mentioned in Issue #671, the babel Hungarian support in LaTeX adds the macro
\aref
to be like\ref
but with support for some special Hungarian grammatical constraints.This PR takes the changes from my magyarbookdown package and includes them in
bookdown
. I'm not sure this is an appropriate addition, but I'll let you decide.