Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error on generating description from a long sentence #1463

Merged
merged 3 commits into from
Apr 3, 2024
Merged

fix: error on generating description from a long sentence #1463

merged 3 commits into from
Apr 3, 2024

Conversation

atusy
Copy link
Collaborator

@atusy atusy commented Apr 3, 2024

fixes #1462

@atusy atusy mentioned this pull request Apr 3, 2024
Closed
yihui
yihui approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's more elegant than my fix. Thanks!

Just add a news item and we'll merge.

@atusy
Copy link
Collaborator Author

atusy commented Apr 3, 2024

Thanks! Added news.

cderv
cderv approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@cderv
Bump dev version
87f8f61 
[skip ci]
@cderv cderv merged commit 65aed2a into rstudio:main Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihui yihui yihui approved these changes

@cderv cderv cderv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bs4_book error: Error in 1:max_n
3 participants
@atusy @yihui @cderv