Ensure mocks config available #2823
Conversation
| @@ -1,5 +1,6 @@ | |||
| require "active_job/base" | |||
| require "active_job/arguments" | |||
There was a problem hiding this comment.
We check if mocks are defined here. Should we do the same here instead of requiring what’s not used?
There was a problem hiding this comment.
The difference is here we are actually using it
There was a problem hiding this comment.
We’re only using it if verified partial doubles are checked, right? Which is not the case when RSpec is configured to mock with an alternative framework. Or am I missing something? It looks like before #2808 everything worked just fine, but apparently rspec-mocks were not required and RSpec::Mocks was not defined, and no problem.
There was a problem hiding this comment.
We don't want to skip the check just because someone is using another mocking framework
There was a problem hiding this comment.
If someone is using another framework, the result of the check will always be false. So it’s not that we skip it, we shortcut it.
JonRowe
force-pushed
the
ensure-mocks-config-available
branch
from
9483480 to
6921c0a
Compare
|
@JonRowe Yes, this works for me! |
Should fix #2822