[WIP] Enable CI for Ruby head

[voxik]

This is just to demonstrate the Ruby 3.4 errors discussed in #2820

[JonRowe]

I'd prefer if you used one of the preview versions

[voxik]

  1) have_broadcasted_to matchers have_broadcasted_to has an appropriate description including the matcher's description when qualified with `#with` and a composable matcher
     Failure/Error:
       expect(
         have_broadcasted_to("my_stream")
           .from_channel(channel)
           .with(a_hash_including(a: :b))
           .description
       ).to eq("have broadcasted exactly 1 messages to my_stream with a hash including #{{:a => :b}}")

       expected: "have broadcasted exactly 1 messages to my_stream with a hash including {:a=>:b}"
            got: "have broadcasted exactly 1 messages to my_stream with a hash including {:a => :b}"

Eh, ok. Failure due to:

rspec-rails/lib/rspec/rails/matchers/base_matcher.rb

Line 138 in 609bb83

inspect_string.gsub(/(\S)=>(\S)/, '\1 => \2')

[voxik]

The Ruby 3.0 tests become broken since yesterday apparently due to RubyGems update 🤷

[voxik]

Not sure about the warning: literal string will be frozen in the future. But I have noticed that the test suite is cloning RSpec components from their original repositories, this should likely change.

[voxik]

Yeah, not sure about Rubocop. Maybe using the "#{{}}" syntax is not good idea and everything should be conditionalized? But something along these lines was kind of suggested here

[JonRowe]

I would extract this to a variable which is defined based on a condition and pass that to raise_error

[voxik]

Could you please elaborate a bit more about the reasons? As I see it, the main advantage of this approach is that the string is still very much reminds the error output. OTOH, if this is extracted into variable, it might have the benefit that Rubocop is happier. Besides that, I'd need to come up with some reasonable variable name, which is always the worst task 🙈

And also is this remark specific to this hunk or in general?

[JonRowe]

Its in general for these interpolated hunks after your rubocop comment e.g.

message =
  if RUBY_VERSION >= '3.4'
    %(attribute {foo: "bar"} was not set on #{record.inspect})
  else
    %(attribute {"foo"=>"bar"} was not set on #{record.inspect})
  end

...

}.to raise_error(message)

[JonRowe]

If you rebase this the main branch fixed the rubygems errors

[voxik]

Rubocop is happy now 👍

But I am not exactly sure about the remaining failures for Ruby 3.4 / Rails 8.0 🤷

[benoittgt]

I've probably fixed the two issues in #2825

[JonRowe]

Thanks @voxik