This repository was archived by the owner on Nov 30, 2024. It is now read-only.
Don't re-close a closed IO (for 2.99) #1544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -5,6 +5,14 @@ | |||
| let(:output) { StringIO.new } | |||
| let(:formatter) { RSpec::Core::Formatters::BaseTextFormatter.new(output) } | |||
|
|
|||
| it 'does not close an already closed output stream' do | |||
| output = File.new("./tmp/output_to_close", "w") | |||
There was a problem hiding this comment.
It looks like the test failures are just that the tmp folder doesn't exist.
There was a problem hiding this comment.
Thanks. I'll fix this up later today.
Fixes #1541 for 2.99.
soulcutter
added a commit
that referenced
this pull request
May 22, 2014
Don't re-close a closed IO (for 2.99)
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…or-2-99 Don't re-close a closed IO (for 2.99) --- This commit was imported from rspec/rspec-core@b355500.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1541. I'll forward port to 3.0 when we get confirmation this fixes the error for the user.