V0ldek/nom 8.0.0 #683
Merged
V0ldek/nom 8.0.0 #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bunch of breaking changes in nom 8.0.0. Nom's maintainers claim it reduces code generated by parsers, which is always worth it. It actually seems to improve performance by roughly 10% on compiling small queries. On larger queries the cost of compilation outweighs the cost of parsing so it's not noticable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
There was a bunch of breaking changes in nom 8.0.0. Nom's maintainers claim it reduces code generated by parsers, which is always worth it.
It actually seems to improve performance by roughly 10% on compiling small queries. On larger queries the cost of compilation
outweighs the cost of parsing so it's not noticable.
Checklist
All of these should be ticked off before you submit the PR.
just verifylocally and it succeeded.