Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0ldek/fix nightly clippy #477

Merged
merged 10 commits into from
Feb 27, 2024
Merged

V0ldek/fix nightly clippy #477

merged 10 commits into from
Feb 27, 2024

Conversation

V0ldek
Copy link
Member

@V0ldek V0ldek commented Feb 27, 2024

Short description

New nightly update includes an improvement to the "unnecessary import" clippy lint which triggered 60-odd warnings. I fixed all occurrences and rolled all current dependabot PRs into this one.

Checklist

All of these should be ticked off before you submit the PR.

  • I ran just verify locally and it succeeded.
  • Issue was given go ahead and is linked above OR I have included justification for a minor change.
  • Unit tests for my changes are included OR no functionality was changed.

dependabot bot and others added 9 commits February 26, 2024 20:44
Bumps the test-deps group in /fuzz with 2 updates: [serde](https://github.com/serde-rs/serde) and [serde_json](https://github.com/serde-rs/json).


Updates `serde` from 1.0.196 to 1.0.197
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.196...v1.0.197)

Updates `serde_json` from 1.0.113 to 1.0.114
- [Release notes](https://github.com/serde-rs/json/releases)
- [Commits](serde-rs/json@v1.0.113...v1.0.114)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-deps
- dependency-name: serde_json
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-deps
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the test-deps group in /crates/rsonpath-test-codegen with 1 update: [serde](https://github.com/serde-rs/serde).


Updates `serde` from 1.0.196 to 1.0.197
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.196...v1.0.197)

---
updated-dependencies:
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: test-deps
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the ci-deps group with 9 updates:

| Package | From | To |
| --- | --- | --- |
| [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact) | `3.0.0` | `3.0.1` |
| [actions/deploy-pages](https://github.com/actions/deploy-pages) | `4.0.3` | `4.0.4` |
| [JasonEtco/create-an-issue](https://github.com/jasonetco/create-an-issue) | `2.9.1` | `2.9.2` |
| [actions/dependency-review-action](https://github.com/actions/dependency-review-action) | `4.0.0` | `4.1.3` |
| [actions/add-to-project](https://github.com/actions/add-to-project) | `0.5.0` | `0.6.0` |
| [actions/upload-artifact](https://github.com/actions/upload-artifact) | `4.3.0` | `4.3.1` |
| [actions/download-artifact](https://github.com/actions/download-artifact) | `4.1.1` | `4.1.2` |
| [EmbarkStudios/cargo-deny-action](https://github.com/embarkstudios/cargo-deny-action) | `1.5.13` | `1.5.15` |
| [github/codeql-action](https://github.com/github/codeql-action) | `3.24.0` | `3.24.5` |


Updates `actions/upload-pages-artifact` from 3.0.0 to 3.0.1
- [Release notes](https://github.com/actions/upload-pages-artifact/releases)
- [Commits](actions/upload-pages-artifact@0252fc4...56afc60)

Updates `actions/deploy-pages` from 4.0.3 to 4.0.4
- [Release notes](https://github.com/actions/deploy-pages/releases)
- [Commits](actions/deploy-pages@87c3283...decdde0)

Updates `JasonEtco/create-an-issue` from 2.9.1 to 2.9.2
- [Release notes](https://github.com/jasonetco/create-an-issue/releases)
- [Commits](JasonEtco/create-an-issue@e27dddc...1b14a70)

Updates `actions/dependency-review-action` from 4.0.0 to 4.1.3
- [Release notes](https://github.com/actions/dependency-review-action/releases)
- [Commits](actions/dependency-review-action@4901385...9129d7d)

Updates `actions/add-to-project` from 0.5.0 to 0.6.0
- [Release notes](https://github.com/actions/add-to-project/releases)
- [Commits](actions/add-to-project@31b3f3c...0609a27)

Updates `actions/upload-artifact` from 4.3.0 to 4.3.1
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@26f96df...5d5d22a)

Updates `actions/download-artifact` from 4.1.1 to 4.1.2
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@6b208ae...eaceaf8)

Updates `EmbarkStudios/cargo-deny-action` from 1.5.13 to 1.5.15
- [Release notes](https://github.com/embarkstudios/cargo-deny-action/releases)
- [Commits](EmbarkStudios/cargo-deny-action@5def368...68cd9c5)

Updates `github/codeql-action` from 3.24.0 to 3.24.5
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@e8893c5...47b3d88)

---
updated-dependencies:
- dependency-name: actions/upload-pages-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: ci-deps
- dependency-name: actions/deploy-pages
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: ci-deps
- dependency-name: JasonEtco/create-an-issue
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: ci-deps
- dependency-name: actions/dependency-review-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: ci-deps
- dependency-name: actions/add-to-project
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: ci-deps
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: ci-deps
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: ci-deps
- dependency-name: EmbarkStudios/cargo-deny-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: ci-deps
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: ci-deps
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the deps group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [clap](https://github.com/clap-rs/clap) | `4.4.18` | `4.5.1` |
| [trycmd](https://github.com/assert-rs/trycmd) | `0.14.20` | `0.15.0` |
| [thiserror](https://github.com/dtolnay/thiserror) | `1.0.56` | `1.0.57` |
| [insta](https://github.com/mitsuhiko/insta) | `1.34.0` | `1.35.1` |
| [serde](https://github.com/serde-rs/serde) | `1.0.196` | `1.0.197` |
| [serde_json](https://github.com/serde-rs/json) | `1.0.113` | `1.0.114` |


Updates `clap` from 4.4.18 to 4.5.1
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](clap-rs/clap@v4.4.18...clap_complete-v4.5.1)

Updates `trycmd` from 0.14.20 to 0.15.0
- [Changelog](https://github.com/assert-rs/trycmd/blob/main/CHANGELOG.md)
- [Commits](assert-rs/snapbox@v0.14.20...v0.15.0)

Updates `thiserror` from 1.0.56 to 1.0.57
- [Release notes](https://github.com/dtolnay/thiserror/releases)
- [Commits](dtolnay/thiserror@1.0.56...1.0.57)

Updates `insta` from 1.34.0 to 1.35.1
- [Changelog](https://github.com/mitsuhiko/insta/blob/master/CHANGELOG.md)
- [Commits](mitsuhiko/insta@1.34.0...1.35.1)

Updates `serde` from 1.0.196 to 1.0.197
- [Release notes](https://github.com/serde-rs/serde/releases)
- [Commits](serde-rs/serde@v1.0.196...v1.0.197)

Updates `serde_json` from 1.0.113 to 1.0.114
- [Release notes](https://github.com/serde-rs/json/releases)
- [Commits](serde-rs/json@v1.0.113...v1.0.114)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: deps
- dependency-name: trycmd
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: deps
- dependency-name: thiserror
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: deps
- dependency-name: insta
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: deps
- dependency-name: serde
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: deps
- dependency-name: serde_json
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: deps
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [auguwu/clippy-action](https://github.com/auguwu/clippy-action) from 48a0d9da70a4eb3fbbb52cd1d753a16fd7e01cc6 to da858d2a352835824fcfdfdba5f5e9fe3cf32d2a.
- [Release notes](https://github.com/auguwu/clippy-action/releases)
- [Commits](auguwu/clippy-action@48a0d9d...da858d2)

---
updated-dependencies:
- dependency-name: auguwu/clippy-action
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@V0ldek V0ldek force-pushed the v0ldek/fix-nightly-clippy branch from 9302283 to e0cf455 Compare February 27, 2024 17:32
@V0ldek V0ldek merged commit 998e75c into main Feb 27, 2024
45 checks passed
@V0ldek V0ldek deleted the v0ldek/fix-nightly-clippy branch February 27, 2024 18:40
@V0ldek V0ldek mentioned this pull request Feb 28, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant