Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sOc=true in status subscriptions #523

Merged
merged 2 commits into from
Jan 31, 2025
Merged

use sOc=true in status subscriptions #523

merged 2 commits into from
Jan 31, 2025

Conversation

emiltin
Copy link
Contributor

@emiltin emiltin commented Jan 31, 2025

No description provided.

@emiltin emiltin added the testhub Set this label to trigger test on test hub equipment label Jan 31, 2025
@emiltin
Copy link
Contributor Author

emiltin commented Jan 31, 2025

sOc was introduces in core 3.1.5. Older core version has no sOc flag, but if you set uRt=0, it means send when there's a change.

https://rsmp-nordic.github.io/rsmp_core/3.1.4/applicability/basic_structure.html#status-messages

So for core<3.1.5, we should set uRt=0, for core>=3.1.5, we should set uRt=0, sOc=true.

@emiltin
Copy link
Contributor Author

emiltin commented Jan 31, 2025

The Cartesio failures are due to no space left on device, so unrelated to this PR change.

@emiltin emiltin changed the title use sendOnChange in status subscriptions use sOc=true in status subscriptions Jan 31, 2025
@emiltin emiltin merged commit ed853fb into main Jan 31, 2025
30 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testhub Set this label to trigger test on test hub equipment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant