Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S0098 config #468

Merged
merged 3 commits into from
Dec 19, 2024
Merged

S0098 config #468

merged 3 commits into from
Dec 19, 2024

Conversation

otterdahl
Copy link
Contributor

@otterdahl otterdahl commented Dec 13, 2024

Issue: #448

Work in progress. It should validate that the response isn't an empty string

@otterdahl
Copy link
Contributor Author

@emiltin The S0098 status doesn't seem to be implemented in the TLC gem?

@emiltin
Copy link
Contributor

emiltin commented Dec 13, 2024

@emiltin The S0098 status doesn't seem to be implemented in the TLC gem?

Right, it just implements enough to pass tests. But I can add support for S0098.

@emiltin
Copy link
Contributor

emiltin commented Dec 13, 2024

Added suppport for S0098 in the rsmp gem, and pulled it into this PR

@emiltin
Copy link
Contributor

emiltin commented Dec 13, 2024

I have to leave for today, back tuesday. Thanks for the PR

@emiltin
Copy link
Contributor

emiltin commented Dec 17, 2024

The test that was added checks that a status response is received. Should we also check that the received attributes have reasonable values, e.g. are not empty?

@emiltin emiltin added the testhub Set this label to trigger test on test hub equipment label Dec 18, 2024
@emiltin
Copy link
Contributor

emiltin commented Dec 18, 2024

Gem TCL now passes all tests.

@otterdahl
Copy link
Contributor Author

otterdahl commented Dec 18, 2024 via email

@emiltin
Copy link
Contributor

emiltin commented Dec 18, 2024

Are there expections for the value of q for any of the attributes?

@emiltin
Copy link
Contributor

emiltin commented Dec 18, 2024

The test now verifies that attributes are not empty.

Should we prevent empty attributes in our schema in the first place?

@emiltin
Copy link
Contributor

emiltin commented Dec 18, 2024

The ITC-3 seems not to implement S0098, returning "unknown status ID". It's running SXL 1.0.15, where S0098 should be available, right? At least that's how the test is currently tagged.

@emiltin emiltin force-pushed the add_S0098 branch 2 times, most recently from 17b977d to 84f78e3 Compare December 18, 2024 15:50
@emiltin
Copy link
Contributor

emiltin commented Dec 18, 2024

@SwarcoPalm
Copy link

@sveitech the ITC-3 seems not to implement S0098? https://github.com/rsmp-nordic/rsmp_validator/actions/runs/12396523470/job/34604744216?pr=468

It requires a bit of setup, we will enable it on the test controller

@emiltin
Copy link
Contributor

emiltin commented Dec 19, 2024

@anezsergi i had to add the 'kapsch-etx' label to the runner again, since it was replaced. Let's see if it picks up jobs now:
https://github.com/rsmp-nordic/rsmp_validator/actions/runs/12396523463/job/34648649864?pr=468

@emiltin emiltin merged commit d29105f into main Dec 19, 2024
43 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testhub Set this label to trigger test on test hub equipment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants