-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S0098 config #468
S0098 config #468
Conversation
@emiltin The S0098 status doesn't seem to be implemented in the TLC gem? |
Right, it just implements enough to pass tests. But I can add support for S0098. |
Added suppport for S0098 in the rsmp gem, and pulled it into this PR |
I have to leave for today, back tuesday. Thanks for the PR |
The test that was added checks that a status response is received. Should we also check that the received attributes have reasonable values, e.g. are not empty? |
Gem TCL now passes all tests. |
The test that was added checks that a status response is received. Should we also check that the received attributes have reasonable values, e.g. are not empty?
Yes. That would be good.
|
Are there expections for the value of |
The test now verifies that attributes are not empty. Should we prevent empty attributes in our schema in the first place? |
The ITC-3 seems not to implement S0098, returning "unknown status ID". It's running SXL 1.0.15, where S0098 should be available, right? At least that's how the test is currently tagged. |
17b977d
to
84f78e3
Compare
@sveitech the ITC-3 seems not to implement S0098? |
It requires a bit of setup, we will enable it on the test controller |
@anezsergi i had to add the 'kapsch-etx' label to the runner again, since it was replaced. Let's see if it picks up jobs now: |
Issue: #448
Work in progress. It should validate that the response isn't an empty string