-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of Transient Storage Opcodes #2778
base: master
Are you sure you want to change the base?
Conversation
The tests are still failing, I am investigating to find the root cause
@@ -984,6 +984,10 @@ | |||
getStorage().addStorageRow(getOwnerRskAddress(), keyWord, valWord); | |||
} | |||
|
|||
public void transientStorageSave(DataWord key, DataWord address) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
@@ -984,6 +984,10 @@ | |||
getStorage().addStorageRow(getOwnerRskAddress(), keyWord, valWord); | |||
} | |||
|
|||
public void transientStorageSave(DataWord key, DataWord address) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
@@ -1094,6 +1098,10 @@ | |||
return getStorage().getStorageValue(getOwnerRskAddress(), key); | |||
} | |||
|
|||
public void transientStorageLoad(DataWord address, DataWord key, DataWord value) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
@@ -1094,6 +1098,10 @@ | |||
return getStorage().getStorageValue(getOwnerRskAddress(), key); | |||
} | |||
|
|||
public void transientStorageLoad(DataWord address, DataWord key, DataWord value) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
@@ -1094,6 +1098,10 @@ | |||
return getStorage().getStorageValue(getOwnerRskAddress(), key); | |||
} | |||
|
|||
public void transientStorageLoad(DataWord address, DataWord key, DataWord value) { |
Check notice
Code scanning / CodeQL
Useless parameter Note
… Arrays.copyOfRange; add more tests
….java Co-authored-by: Nazaret García Revetria <[email protected]>
d6dc804
to
8892bf3
Compare
This PR aims to implements the RSKIP-446 that handles the transient storage opcodes defined int he RSKIP-446, which aims to be compatible with EIP-1153 from Ethereum.
The PR still in draft mode because some tests need to be fixed and added.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: