Avoiding random nonce in MinerClientImpl

rsksmart · Jul 2, 2017 · 7ef1e22 · 7ef1e22
1 parent 237f405
commit 7ef1e22
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/rskj-core/src/main/java/co/rsk/mine/MinerClientImpl.java b/rskj-core/src/main/java/co/rsk/mine/MinerClientImpl.java
@@ -31,7 +31,6 @@
 
 import javax.annotation.Nonnull;
 import java.math.BigInteger;
-import java.util.Random;
 import java.util.Timer;
 import java.util.TimerTask;
 
@@ -43,7 +42,7 @@
 
 @Component("MinerClient")
 public class MinerClientImpl implements MinerClient {
-    private static Random random = new Random();
+    private long nextNonceToUse = 0;
 
     @Autowired
     private Rsk rsk;
@@ -173,7 +172,7 @@ public boolean mineBlock() {
      */
     private boolean findNonce(@Nonnull final co.rsk.bitcoinj.core.BtcBlock bitcoinMergedMiningBlock,
                               @Nonnull final BigInteger target) {
-        bitcoinMergedMiningBlock.setNonce(random.nextLong());
+        bitcoinMergedMiningBlock.setNonce(nextNonceToUse++);
 
         while (!stop && !newBestBlockArrivedFromAnotherNode) {
             // Is our proof of work valid yet?
@@ -182,7 +181,7 @@ private boolean findNonce(@Nonnull final co.rsk.bitcoinj.core.BtcBlock bitcoinMe
                 return true;
             }
             // No, so increment the nonce and try again.
-            bitcoinMergedMiningBlock.setNonce(bitcoinMergedMiningBlock.getNonce() + 1);
+            bitcoinMergedMiningBlock.setNonce(nextNonceToUse++);
             if (bitcoinMergedMiningBlock.getNonce() % 100000 == 0) {
                 logger.debug("Solving block. Nonce: " + bitcoinMergedMiningBlock.getNonce());
             }