Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

US-2088 EOA Seedless version #868

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

US-2088 EOA Seedless version #868

wants to merge 12 commits into from

Conversation

TravellerOnTheRun
Copy link
Collaborator

@TravellerOnTheRun TravellerOnTheRun commented Jan 23, 2024 •
edited
Loading

This PR adds Magic Seedless EOA version of the Wallet.
Make sure you have .env file added locally, see .env.example file for the properties that are required for the app to run.

@TravellerOnTheRun TravellerOnTheRun self-assigned this Jan 23, 2024
@TravellerOnTheRun TravellerOnTheRun marked this pull request as draft January 23, 2024 09:21
@TravellerOnTheRun TravellerOnTheRun marked this pull request as ready for review January 25, 2024 08:43
@jormelCoin
Copy link
Contributor

Hey @TravellerOnTheRun, I got this error message when built the app on my device.

IMG_0042

@TravellerOnTheRun
Copy link
Collaborator Author

Hey @TravellerOnTheRun, I got this error message when built the app on my device.

IMG_0042

Please, make sure to add .env file locally in the root directory and add values from squad-wallet-tech channel in Slack

@jessgusclark
Copy link
Member

jessgusclark commented Jan 31, 2024 •
edited
Loading

Commented on wrong PR. Moving to correct one...

jormelCoin
jormelCoin requested changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@jormelCoin jormelCoin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TravellerOnTheRun
I saw two things:
1- When running the app, your session is active. Namely, your email is set up by Defect.
2- It still remains the issue that when switching between mainnet and testnet gets disconnected.

@TravellerOnTheRun
Copy link
Collaborator Author

@TravellerOnTheRun I saw two things: 1- When running the app, your session is active. Namely, your email is set up by Defect. 2- It still remains the issue that when switching between mainnet and testnet gets disconnected.

@jormelCoin
I've rebased the PR on recent develop, try testing again.

@TravellerOnTheRun TravellerOnTheRun removed the dont merge Do not merge this PR label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessgusclark jessgusclark Awaiting requested review from jessgusclark

@jormelCoin jormelCoin Awaiting requested review from jormelCoin

Requested changes must be addressed to merge this pull request.

Assignees

@TravellerOnTheRun TravellerOnTheRun

Labels
Ready for Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TravellerOnTheRun @jormelCoin @jessgusclark