This repository has been archived by the owner on Jul 7, 2020. It is now read-only.
Fix issue-9, all tests pass #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix is to use Eval() instead of EvalNode() to get the type of a expr. To use Eval, we have to retrive the expression text of the rhs expr, thus we pass grinder.EditBuffer to hasType() and retrive expression text by EditBuffer#TextAt.
|
Hi @xwb1989 I merged your code into jackspirou/grind so that I could run |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #9
The fix is to use Eval() instead of EvalNode() to get the type of an expr.
To use Eval, we have to retrive the expression text of the rhs expr,
thus we pass grinder.EditBuffer to hasType() and retrive expression text by EditBuffer#TextAt.