Skip to content
This repository has been archived by the owner on Jul 7, 2020. It is now read-only.

Grind depends on types.EvalNode #9

Open
attilaolah opened this issue Jun 17, 2015 · 10 comments · May be fixed by #10
Open

Grind depends on types.EvalNode #9

attilaolah opened this issue Jun 17, 2015 · 10 comments · May be fixed by #10

Comments

@attilaolah
Copy link 

/go/src/rsc.io/grind/vardecl/vardecl.go:88: undefined: types.EvalNode
@attilaolah attilaolah changed the title Grind depends on Go 1.5 types.EvalNode Grind depends on types.EvalNode Jun 17, 2015
@attilaolah
Copy link
Author

Looks like types.EvalNood has been removed in golang/tools@665374f.

@mvdan
Copy link

mvdan commented Aug 14, 2015

Bump! I can't go get it :(

@fekle
Copy link

fekle commented Sep 10, 2015

Yeah, here's hoping this will get updated - really loved this tool :)
Unfortunately, my Go skills are not quite good enough yet for submitting a pull request..

@shawnps
Copy link

shawnps commented Oct 3, 2015

Would also like to see this fixed, was hoping to integrate it into Go Report Card http://goreportcard.com/

@shawnps shawnps mentioned this issue Oct 3, 2015
Closed
@attilaolah
Copy link
Author

I think grind is becoming less and less attractive, esp. now that there's gometalinter.

@dgryski
Copy link

dgryski commented Oct 12, 2015

No other tool does the same code rewrites that grind does.

@anacrolix
Copy link

Did*.

@xwb1989 xwb1989 linked a pull request Oct 14, 2015 that will close this issue
Open
@jackspirou
Copy link

I forked the code at jackspirou/grind and added the fix that @xwb1989 provided. I just wanted a place that I could run go get against and pickup PR #10. I would have just used the fork @xwb1989 had to submit the PR, but the import paths need to match the repo for a proper go get.

I ended up with go get github.com/jackspirou/grind for grind on Go versions 1.4+.

I know this is an old issue, but I thought it might help someone who is looking for a quick go get of grind.

@tylerstillwater
Copy link

@jackspirou Trying to go get your fork doesn't work for me:

go get github.com/jackspirou/grind
# github.com/jackspirou/grind/vardecl
../../jackspirou/grind/vardecl/vardecl.go:89: xScope.Pos undefined (type *types.Scope has no field or method Pos)
../../jackspirou/grind/vardecl/vardecl.go:89: too many arguments in call to types.Eval

I would have created an issue on your fork, but you don't have issues enabled.

@jackspirou
Copy link

@tylerb issues are now enabled. What version of go are you using? Just curious, since the travis tests pass on 1.4+. I'll see if I can debug it, please open an issue :)

EDIT:

on go version go1.5.1 darwin/amd64 everything builds with:

$ go get -u -v github.com/jackspirou/grind                                                                                                     
github.com/jackspirou/grind (download)
Fetching https://golang.org/x/tools/go/gcimporter?go-get=1
Parsing meta tags from https://golang.org/x/tools/go/gcimporter?go-get=1 (status code 200)
get "golang.org/x/tools/go/gcimporter": found meta tag main.metaImport{Prefix:"golang.org/x/tools", VCS:"git", RepoRoot:"https://go.googlesource.com/tools"} at https://golang.org/x/tools/go/gcimporter?go-get=1
get "golang.org/x/tools/go/gcimporter": verifying non-authoritative meta tag
Fetching https://golang.org/x/tools?go-get=1
Parsing meta tags from https://golang.org/x/tools?go-get=1 (status code 200)
golang.org/x/tools (download)
Fetching https://golang.org/x/tools/go/exact?go-get=1
Parsing meta tags from https://golang.org/x/tools/go/exact?go-get=1 (status code 200)
get "golang.org/x/tools/go/exact": found meta tag main.metaImport{Prefix:"golang.org/x/tools", VCS:"git", RepoRoot:"https://go.googlesource.com/tools"} at https://golang.org/x/tools/go/exact?go-get=1
get "golang.org/x/tools/go/exact": verifying non-authoritative meta tag
Fetching https://golang.org/x/tools/go/types?go-get=1
Parsing meta tags from https://golang.org/x/tools/go/types?go-get=1 (status code 200)
get "golang.org/x/tools/go/types": found meta tag main.metaImport{Prefix:"golang.org/x/tools", VCS:"git", RepoRoot:"https://go.googlesource.com/tools"} at https://golang.org/x/tools/go/types?go-get=1
get "golang.org/x/tools/go/types": verifying non-authoritative meta tag
github.com/jackspirou/grind/flow
github.com/jackspirou/grind/block
github.com/jackspirou/grind/grinder
github.com/jackspirou/grind/deadcode
github.com/jackspirou/grind/vardecl
github.com/jackspirou/grind/gotoinline
github.com/jackspirou/grind

EDIT: issue resolved here: jackspirou#1

@jackspirou jackspirou mentioned this issue Mar 8, 2016
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue-9, all tests pass xwb1989/grind
8 participants
@tylerstillwater @shawnps @attilaolah @dgryski @anacrolix @mvdan @fekle @jackspirou