Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that ee()->TMPL is not overwritten #62

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

domstubbs
Copy link
Collaborator

I posted a comment about this yesterday and thought I might as well submit a PR with the changes I’ve made locally. This does feel like a bit of a bodge, but the issue seems to have affected quite a few people (my guess is it’s the source of all missing tagparams problems) and this is proving to be a reliable fix for me.

@rsanchez
Copy link
Owner

Hi Dom,

I don't really work with EE anymore or have time to service this add-on. Can I give you write access to this repo so you can patch things yourself?

@domstubbs
Copy link
Collaborator Author

Sure, I can merge these in and commit a point update if you’re happy with the changes.

I’ve stopped developing with EE as well, but this plugin is proving invaluable for migrating content from an old site over to Craft.

I’ll be working on the migration over the next few days, so maybe it’s best if I wait and see if any other issues crop up, then merge these PRs and bump the version number once I’m done.

Thanks for your work on this btw, I’m using it with the FeedMe Craft plugin and it’s working a treat.

@domstubbs domstubbs merged commit ca4fdc9 into rsanchez:master Nov 28, 2017
@domstubbs domstubbs deleted the tmpl-fix branch November 28, 2017 11:25
@domstubbs
Copy link
Collaborator Author

I’ve merged my PRs and committed a point update which also adds hooks for the entries and members methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants