Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom phase input as a general example #89

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Conversation

tjlane
Copy link
Collaborator

@tjlane tjlane commented Nov 29, 2024

@DHekstra was interested in running meteor.diffmap but using pre-computed phases rather than those computed from a model.

I actually started extending the CLI (meteor.diffmap) to facilitate this, but then decided against it. The logic in the CLI is starting to get complex, and I want to limit it as much as possible to the "normal" use case, guiding non-expert users.

So instead, I thought maybe this would be a great case for a notebook example of how to use the meteor library to do more custom things. Here's a proposed notebook. @DHekstra, as a user, I'm curious how your experience/vibes are here.

Aims to resolve #77.

@tjlane tjlane self-assigned this Nov 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.62%. Comparing base (84da814) to head (2d8a0a0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   95.56%   95.62%   +0.06%     
==========================================
  Files          15       15              
  Lines         925      938      +13     
==========================================
+ Hits          884      897      +13     
  Misses         41       41              
Flag Coverage Δ
unittests 95.62% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjlane
Copy link
Collaborator Author

tjlane commented Dec 17, 2024

@DHekstra and @alisiafadini let me know if you have any feedback here 🙏

Copy link
Collaborator

@alisiafadini alisiafadini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of having notebook examples for using the library instead of complicating the logic from the main scripts!

I also find the notebook clear – though @DHekstra might be a better judge in this case, as a potential user. I'm probably biased!

@tjlane tjlane merged commit 8769c2f into main Jan 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable phase column input
3 participants