Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyproject.toml and CI actions #6

Merged
merged 6 commits into from
Aug 11, 2024
Merged

pyproject.toml and CI actions #6

merged 6 commits into from
Aug 11, 2024

Conversation

tjlane
Copy link
Collaborator

@tjlane tjlane commented Aug 11, 2024 •
edited
Loading

First: this PR adds GH action templates for:

  • testing
  • lint (ruff)
  • type checking (mypy)

These will fail at first run.

Second: this PR replaces setup.py with a pyproject.toml.

@tjlane tjlane requested a review from alisiafadini August 11, 2024 14:56
alisiafadini
alisiafadini approved these changes Aug 11, 2024
View reviewed changes
Copy link
Collaborator

@alisiafadini alisiafadini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small fixes, otherwise lgtm

.github/workflows/mypy.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@tjlane tjlane merged commit 0d50074 into meteor_v2 Aug 11, 2024
0 of 3 checks passed
@tjlane tjlane deleted the tjlane/build branch August 11, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisiafadini alisiafadini alisiafadini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjlane @alisiafadini