Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove git lfs #54

Merged
merged 2 commits into from
Oct 30, 2024
Merged

remove git lfs #54

merged 2 commits into from
Oct 30, 2024

Conversation

tjlane
Copy link
Collaborator

@tjlane tjlane commented Oct 29, 2024

Previously, we had been using git lfs to track a single 3.5 MB MTZ file. This was a bit excessive, and caused @virginia4 headaches today.

I think I was able to purge LFS from the repo by following the instructions here:
git-lfs/git-lfs#3026

@virginia4 could you try to install this branch with the following (modified) command:

pip install git+https://github.com/alisiafadini/meteor.git@tjlane/rm-lfs

Once we have proper CI/CD these problems should disappear :). Thanks @virginia4 for helping find this problem!!!

@tjlane tjlane self-assigned this Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.60%. Comparing base (3de2bbd) to head (cc316f4).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #54   +/-   ##
=======================================
  Coverage   96.60%   96.60%           
=======================================
  Files          14       14           
  Lines         854      854           
=======================================
  Hits          825      825           
  Misses         29       29           
Flag Coverage Δ
unittests 96.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@virginia4
Copy link
Collaborator

The new repository (https://github.com/alisiafadini/meteor.git@tjlane/rm-lfs) cannot be found I'm afraid.

@virginia4
Copy link
Collaborator

I homebrew-installed git-lfs and then cloned from the master (git+https://github.com/alisiafadini/meteor) and it works! So that was definitely the issue for me. But it's better wot be independent from lfs, so it will be good to get the https://github.com/alisiafadini/meteor.git@tjlane/rm-lfs working

@virginia4 virginia4 merged commit 2405dfd into master Oct 30, 2024
5 checks passed
@tjlane tjlane deleted the tjlane/rm-lfs branch November 1, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants