Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CondFinalCondition readability check #1042

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Stratus3D
Copy link
Contributor

I am re-opening this PR as I'm uncertain my comment on the previously closed PR were seen. Specifically, see #935 (comment)

This PR adds a check named Credo.Check.Readability.CondCatchallTrue that checks for conds that end in a catchall clause that use a literal value other than true. I created this check to catch violations of the rule about catchall cond clauses specified in the Christopher Adam's style guide (https://github.com/christopheradams/elixir_style_guide#true-as-last-condition). See the tests for examples.

Context:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant