Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vue-recommended/element-attribute-order rule w tests #92

Merged
merged 4 commits into from
Aug 3, 2024

Conversation

David-Pena
Copy link
Collaborator

No description provided.


console.log(`\n${TEXT_INFO}vue-recommended${TEXT_RESET} ${BG_ERR}element attribute order ${BG_RESET} detected in ${fileCount} files.`)
console.log(
`👉 ${TEXT_WARN}Whenever a build system is available to concatenate files, each component should be in its own file.${TEXT_RESET} See: https://vuejs.org/style-guide/rules-strongly-recommended.html#component-files`,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in the last commit

Copy link
Owner

@rrd108 rrd108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text of the cli output is also to be changed, right?

@David-Pena
Copy link
Collaborator Author

The text of the cli output is also to be changed, right?

Fixed in the last commit 😅 my bad

@rrd108 rrd108 merged commit ab0d9b8 into main Aug 3, 2024
2 checks passed
@David-Pena David-Pena deleted the vue-recommended/element-attribute-order branch August 3, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants