feat: add babel parser and traverse and migrate some rules

[David-Pena]

Summary

Adds babel parser and traverse packages for AST parsing for some rules.

Description

• rule functionSize refactored with babel
• rule parameterCount refactored with babel
• rule computedSideEffects refactored with babel
• Extract some reusable blocks to /helpers

Related Issues

Supports #368
Fixes #365 #364 #431

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Screenshots (if applicable)

N/A

[github-actions]

Vue Mess Detector Analysis Results

🚨 New Errors: 3
⚠️ New Warnings: 4
✅ Fixed Errors: 0
🔧 Fixed Warnings: 0
📝 Total Lines: 227
📁 Total Files: 2

New Issues

- src/rules/rrd/repeatedCss.ts:
  rrd ~ else conditions: else clauses found (1) 🚨
  rrd ~ function size: function (checkRepeatedCss#14) is too long: 32 lines 🚨
  rrd ~ magic numbers: magic numbers found (line #53 magic number: 3) 🚨
- src/rules/rrd/repeatedCss.test.ts:
  rrd ~ Long <script> blocks: (152 lines) 🚨

🔍 Download Full Analysis Details

For any issues or feedback, feel free to report them here.

[pkg-pr-new]

Open in Stackblitz

npm i https://pkg.pr.new/rrd108/vue-mess-detector@448

commit: cc38221

[David-Pena]

not ready to merge, there is a weird bug when running the cli tests

[David-Pena]

not ready to merge, there is a weird bug when running the cli tests

It seems to be something with the traverse logic because if functionSize, parameterCount and computedSideEffects rules are commented, the error dissapears.

There is a file inside the project which is causing that error when walking through it... I'm still debugging 👀

[rrd108]

@David-Pena there are too many conflicts to fix manually. Can you just delete and regenrate the lock file?

[David-Pena]

Oh no worries, I will. I'll be sitting in front of this issue this weekend🫡

[rrd108]

@David-Pena can you check the failing tests and update yarn.lock?

[David-Pena]

I'm back 👨🏼‍💻

[github-actions]

Vue Mess Detector Analysis Results

🚨 New Errors: 0
⚠️ New Warnings: 0
✅ Fixed Errors: 0
🔧 Fixed Warnings: 0
📝 Total Lines: 0
📁 Total Files: 0

🔍 Download Full Analysis Details

For any issues or feedback, feel free to report them here.

[rrd108]

did the tests passed on your end?

[David-Pena]

did the tests passed on your end?

Still debugging...

I'm getting an error traverse is not a function but I'm pretty sure I'm importing it correctly, so I doing a bit of research

[rrd108]

Ah ok. I thought it is ready to merge and then I saw the failing tests.

No worries, take your time.

It is ok if it is ready only next year.

[David-Pena]

The weird thing is that the specific tests for each of the changed rules pass! and the traverse logic is working because its logging something I just add

But when I run this test

The output says this: traverse is not a function

I'm not sure if its because the runCLI function runs the npx command and as the released version does not have the new package @babel/parser or smth like that... @rrd108 what do you think?

[rrd108]

Try to run build and then run the test

[David-Pena]

Try to run build and then run the test

Done it already and the same... would you mind moving to my branch and try to build then run the tests?

I shouldnt need to use another parser I think... (but I'm kind of stuck)

[rrd108]

I am confused...

I switched to this branch, yarn install yarn build and I get compeltely different error messages for the test.

I confirm the computedSideEffect test is passing by its own.

But here is the output for me running the tests

And here is the output running analyze

[David-Pena]

Oh for the screenshot I showed you I commented the parameterCount and functionSize rule in ruleCheck/ruleReport and the array of rules because my plan was to debug first one of the changed rules computedSideEffects.

And I printed the entire response, not only the stdout, I think that way I found the traverse is not a function error