feat: add rule no inline styles #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR ci failed, please check the details 👀 |
|
Hi @Whomy09
You can check details by running |
rrd108
reviewed
Sep 5, 2024
src/rules/rrd/noInlineStyles.ts
Outdated
| const matches = [...template.content.matchAll(regex)] | ||
|
|
||
| matches?.forEach((match) => { | ||
| const lineNumber = getLineNumber(template.content.trim(), match[0]) |
There was a problem hiding this comment.
please add the from parameter here otherwise if the same pattern found multiple times, it will report the same line number for them
rrd108
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A new rule was added and the respective documentation was also added.
Related Issues
#206
Type of Change