Skip to content

Commit

Permalink
fix: return when file is not a test file (#395)
Browse files Browse the repository at this point in the history
  • Loading branch information
David-Pena committed Oct 12, 2024
1 parent 0281b15 commit 201753b
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 4 deletions.
23 changes: 20 additions & 3 deletions src/rules/rrd/noSkippedTests.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,24 @@ describe('checkNoSkippedTests', () => {
})
`,
} as SFCScriptBlock
const fileName = 'no-skipped-tests.vue'
const fileName = 'no-skipped-tests.test.ts'
checkNoSkippedTests(script, fileName)
const result = reportNoSkippedTests()
expect(result.length).toBe(0)
expect(result).toStrictEqual([])
})

it('should not report non-test files', () => {
const script = {
content: `
const navigateSkip = async () => {
const state = getAuthFlow().getState<'onboarding_username'>();
const nextState = await state!.actions.skip(null).run();
getAuthFlow().handlers[nextState.name](nextState as any);
};
`,
} as SFCScriptBlock
const fileName = 'non-test.ts'
checkNoSkippedTests(script, fileName)
const result = reportNoSkippedTests()
expect(result.length).toBe(0)
Expand All @@ -30,7 +47,7 @@ describe('checkNoSkippedTests', () => {
})
`,
} as SFCScriptBlock
const fileName = 'todo-tests.vue'
const fileName = 'todo-tests.test.ts'
checkNoSkippedTests(script, fileName)
const result = reportNoSkippedTests()
expect(result.length).toBe(1)
Expand All @@ -56,7 +73,7 @@ describe('checkNoSkippedTests', () => {
})
`,
} as SFCScriptBlock
const fileName = 'skipped-tests.vue'
const fileName = 'skipped-tests.test.ts'
checkNoSkippedTests(script, fileName)
const result = reportNoSkippedTests()
expect(result.length).toBe(2)
Expand Down
2 changes: 1 addition & 1 deletion src/rules/rrd/noSkippedTests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const results: FileCheckResult[] = []
const resetResults = () => (results.length = 0)

const checkNoSkippedTests = (script: SFCScriptBlock | null, filePath: string) => {
if (!script) {
if (!script || !filePath.includes('.test')) {
return
}

Expand Down

0 comments on commit 201753b

Please sign in to comment.