refactor to satisfy no else condition rule

rrd108 · Aug 22, 2024 · 1c2826e · 1c2826e
1 parent 2e556f5
commit 1c2826e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/src/missingRules.js b/src/missingRules.js
@@ -26,7 +26,7 @@ const findRules = async (srcDir) => {
       if (stat.isDirectory()) {
         await traverseDirectory(fullPath)
       }
-      else if (isValidSourceFile(currentPath, file)) {
+      if (isValidSourceFile(currentPath, file)) {
         allRules.push(`${currentPath}/${file}`)
       }
     }
@@ -84,7 +84,9 @@ const main = async () => {
       console.error(`\n${errors} errors were found during the check.\n`)
       // eslint-disable-next-line node/prefer-global/process
       process.exit(1) // Exit with error code
-    } else {
+    }
+
+    if (!errors) {
         console.log('All checks passed successfully.')
     }
 }

diff --git a/src/rules/rrd/parameterCount.ts b/src/rules/rrd/parameterCount.ts
@@ -31,7 +31,7 @@ const checkParameterCount = (script: SFCScriptBlock | null, filePath: string) =>
       // Regular function
       checkParameters(match[1], match[2], filePath) // match[2] are the params for current regular function
     }
-    else if (match[3]) {
+    if (match[3]) {
       // Arrow function
       checkParameters(match[3], match[4], filePath) // match[4] are the params for current arrow function
     }

diff --git a/src/rulesReport.ts b/src/rulesReport.ts
@@ -143,7 +143,9 @@ export const reportRules = (groupBy: GroupBy, orderBy: OrderBy, level: OutputLev
 
       if (groupBy === 'file') {
         output.push({ info: `   Rule: ${offense.rule}` })
-      } else {
+      }
+
+      if (groupBy !== 'file') {
         output.push({ info: `   File: ${offense.file}` })
       }
       output.push({ info: `   Description: ${offense.description}` })