Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for invalid things #3646

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Conversation

dzaima
Copy link
Contributor

@dzaima dzaima commented Nov 11, 2023

This fixes a couple things:

  • delete checkpoint without an argument reads outside array bounds

  • Checkpoints created at the end state, or when the process has finished, cannot be functionally restored, so disallow those

  • After a failed run, gdb generally doesn't query anything, except info threads (perhaps there are more, but I haven't looked). And if rr responds with any threads, things soon break. Perhaps there's a better way to check for/handle this than my introduced bool failed_restart;?

@khuey
Copy link
Collaborator

khuey commented Dec 14, 2023

How does gdb ever get fixed once failed_restart is set to true?

@dzaima
Copy link
Contributor Author

dzaima commented Dec 14, 2023

Oh is that why thread listing started sometimes not showing threads beyond the active one.. looking into it.

@dzaima
Copy link
Contributor Author

dzaima commented Dec 14, 2023

Should be good now. failed_restart being unset at the same place as in_debuggee_end_state makes sense.

@rocallahan
Copy link
Collaborator

Can you fold your fixes into the original commits they modify?

@dzaima
Copy link
Contributor Author

dzaima commented Feb 23, 2024

Rebased to latest, and added a fix of a new problem which happens to already get caught by two of my modified tests here - a simple c; c; when (or any rr-cmd) resulted in a python error.

@rocallahan rocallahan merged commit 53e4b37 into rr-debugger:master Feb 26, 2024
4 checks passed
@rocallahan
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants