Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple things:
delete checkpoint
without an argument reads outside array boundsCheckpoints created at the end state, or when the process has finished, cannot be functionally restored, so disallow those
After a failed
run
, gdb generally doesn't query anything, exceptinfo threads
(perhaps there are more, but I haven't looked). And if rr responds with any threads, things soon break. Perhaps there's a better way to check for/handle this than my introducedbool failed_restart;
?