export RQ statistics as prometheus metrics #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencehonles
force-pushed
the
export-prometheus-metrics
branch
3 times, most recently
from
288bbf5 to
30e3eb4
Compare
terencehonles
commented
Aug 16, 2024
terencehonles
force-pushed
the
export-prometheus-metrics
branch
5 times, most recently
from
79f6394 to
70f07f8
Compare
terencehonles
force-pushed
the
export-prometheus-metrics
branch
from
70f07f8 to
de7de29
Compare
terencehonles
force-pushed
the
export-prometheus-metrics
branch
from
de7de29 to
84c84bf
Compare
selwin
reviewed
Dec 17, 2024
|
|
||
| with self.summary.time(): | ||
| rq_workers = GaugeMetricFamily('rq_workers', 'RQ workers', labels=['name', 'state', 'queues']) | ||
| rq_workers_success = CounterMetricFamily('rq_workers_success', 'RQ workers success count', labels=['name', 'queues']) |
There was a problem hiding this comment.
Can you rename rq_workers_success to successful_job_count?
selwin
reviewed
Dec 17, 2024
| rq_workers = GaugeMetricFamily('rq_workers', 'RQ workers', labels=['name', 'state', 'queues']) | ||
| rq_workers_success = CounterMetricFamily('rq_workers_success', 'RQ workers success count', labels=['name', 'queues']) | ||
| rq_workers_failed = CounterMetricFamily('rq_workers_failed', 'RQ workers fail count', labels=['name', 'queues']) | ||
| rq_workers_working_time = CounterMetricFamily('rq_workers_working_time', 'RQ workers spent seconds', labels=['name', 'queues']) |
|
I don't mind merging this in, but could you document this feature? A simple unit test to show that this view works would also be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change follows the implementation of
rq_exporterand the prometheus client to export the RQ statistics as a Django view.fixes: #503