Use actual repository ID in stored transactions v2 #2093
+66
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the repositories are created from config files. But commands like `dnf offline _execute` can choose not to create them.
m-blaha
requested review from
jrohel and
kontura
and removed request for
a team
kontura
approved these changes
Mar 3, 2025
dnf5/commands/offline/offline.cpp
Outdated
| @@ -390,6 +390,9 @@ void OfflineExecuteCommand::pre_configure() { | |||
| // checked when the transaction was prepared and serialized. This way, we | |||
| // don't need to keep track of which packages need to be gpgchecked. | |||
| ctx.get_base().get_config().get_pkg_gpgcheck_option().set(false); | |||
|
|
|||
| // do not create repos from the system configuration | |||
There was a problem hiding this comment.
I think it would be even more helpful to also describe why we don't create repos from the system configs.
There was a problem hiding this comment.
Thank you. I've amended the commit with more descriptive comment.
Currently, when replaying a stored transaction, all RPM files are
placed into a single `@stored_transaction` repository. The user can see
this artifitial repository when checking from which repositories the
installed packages came:
❯ dnf repoquery --installed --queryformat="%{full_nevra} %{from_repo}\n"
vlc-plugin-gstreamer-1:3.0.21-15.fc40.x86_64 @stored_transaction
This can be confusing, especially during a system upgrade, which also
uses stored transactions.
With this patch, local RPM files from stored transactions are
placed to the repository they originally came from:
❯ dnf repoquery --installed --queryformat="%{full_nevra} %{from_repo}\n"
vlc-plugin-gstreamer-1:3.0.21-15.fc40.x86_64 updates
Fixes: #1851
m-blaha
force-pushed
the
mblaha/system-upgrade-repos-on-the-fly
branch
from
e24c4c1 to
681b1c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is alternative solution to #2061
Currently, when replaying a stored transaction, all RPM files are placed
into a single
@stored_transactionrepository. The user can see thisartifitial repository when checking from which repositories the installed
packages came:
❯ dnf repoquery --installed --queryformat="%{full_nevra} %{from_repo}\n"
vlc-plugin-gstreamer-1:3.0.21-15.fc40.x86_64 @stored_transaction
This can be confusing, especially during a system upgrade, which also uses
stored transactions.
With this patch, local RPM files from stored transactions are placed to the
repository they originally came from:
❯ dnf repoquery --installed --queryformat="%{full_nevra} %{from_repo}\n"
vlc-plugin-gstreamer-1:3.0.21-15.fc40.x86_64 updates
Fixes: #1851