test: prevent rpmbuild from writing to system rpmdb

[pastalian]

rpmbuild with default dbpath will write to /var/lib/rpm. Set it to the temporary directory.

[Conan-Kudo]

This means it cannot read dependencies installed on the system for building packages.

[Conan-Kudo]

And this is a problem because we don't use --nodeps, so we actually do expect to have build deps installed.

[pastalian]

Is there a possibility to add build-time dependencies to test packages? They don't have any and testcases will pass right now.

[Conan-Kudo]

Maybe? I'm not sure.

[ppisar]

In my opinion, DNF5 tests should be self-contained, i.e. independent from the system RPM database. But I worry many of them are not. If rpmbuild --dbpath breaks the tests, the tests needs to be fixed in the pull request or before this pull request.

[pmatilai]

Eh, rpmbuild does not write to rpmdb. It will only read from it, and the only situation where that will result in actual writing is when the database doesn't exist at all.

What is the actual problem you're experiencing?

[pastalian]

@pmatilai The main rpmdb itself does not get written as you say, but its WAL related files rpmdb.sqlite-{shm,wal} do.
I found this issue when trying to build dnf5 with Gentoo, which detects sandbox violations.

detail

 * ----------------------- SANDBOX ACCESS VIOLATION SUMMARY -----------------------
 * LOG FILE: "/var/tmp/portage/sys-apps/dnf5-5.1.12/temp/sandbox.log"
 * 
VERSION 1.0
FORMAT: F - Function called
FORMAT: S - Access Status
FORMAT: P - Path as passed to function
FORMAT: A - Absolute Path (not canonical)
FORMAT: R - Canonical Path
FORMAT: C - Command Line

F: open_wr
S: deny
P: /var/lib/rpm/rpmdb.sqlite-wal
A: /var/lib/rpm/rpmdb.sqlite-wal
R: /var/lib/rpm/rpmdb.sqlite-wal
C: rpmbuild -ba --define=_topdir /var/tmp/portage/sys-apps/dnf5-5.1.12/temp/tmp.3Nm4YQBFMS --define=_srcrpmdir /var/tmp/portage/sys-apps/dnf5-5.1.12/work/dnf5-5.1.12_build/test/data/cmdline-rpms --define=_rpmdir /var/tmp/portage/sys-apps/dnf5-5.1.12/work/dnf5-5.1.12_build/test/data/cmdline-rpms --define=_build_name_fmt %%{NAME}-%%{VERSION}-%%{RELEASE}.%%{ARCH}.rpm --define=_source_payload w1.gzdio --define=_binary_payload w1.gzdio /var/tmp/portage/sys-apps/dnf5-5.1.12/work/dnf5-5.1.12/test/data/cmdline-rpms/cmdline-1.2-3.spec

F: open_wr
S: deny
P: /var/lib/rpm/rpmdb.sqlite-shm
A: /var/lib/rpm/rpmdb.sqlite-shm
R: /var/lib/rpm/rpmdb.sqlite-shm
C: rpmbuild -ba --define=_topdir /var/tmp/portage/sys-apps/dnf5-5.1.12/temp/tmp.3Nm4YQBFMS --define=_srcrpmdir /var/tmp/portage/sys-apps/dnf5-5.1.12/work/dnf5-5.1.12_build/test/data/cmdline-rpms --define=_rpmdir /var/tmp/portage/sys-apps/dnf5-5.1.12/work/dnf5-5.1.12_build/test/data/cmdline-rpms --define=_build_name_fmt %%{NAME}-%%{VERSION}-%%{RELEASE}.%%{ARCH}.rpm --define=_source_payload w1.gzdio --define=_binary_payload w1.gzdio /var/tmp/portage/sys-apps/dnf5-5.1.12/work/dnf5-5.1.12/test/data/cmdline-rpms/cmdline-1.2-3.spec

[pmatilai]

There wouldn't be any system rpmdb on Gentoo.

[ppisar]

--nodeps is not good. The tests needs to be adapted to resolve all dependencies from a nonsystem --dbpath.