Revert "Use focusbest: prefer latest deps versions over smaller transactions #1211
Conversation
|
What about to make the flag optional? In past we've got several reports where users complained that transaction is performed with not latest packages. In case that I have a package |
Yes as I wrote in the description I would first wait for the response from libsolv and depending on that we can either make it a new option or do something else. But I think we should do this revert as soon as possible because the behavior is really not great. |
libdnf5/CMakeLists.txt
Outdated
| @@ -51,7 +51,7 @@ pkg_check_modules(LIBMODULEMD REQUIRED modulemd-2.0>=2.11.2) | |||
| list(APPEND LIBDNF5_PC_REQUIRES "${LIBMODULEMD_MODULE_NAME}") | |||
| target_link_libraries(libdnf5 PRIVATE ${LIBMODULEMD_LIBRARIES}) | |||
|
|
|||
| pkg_check_modules(LIBSOLV REQUIRED libsolv>=0.7.25) | |||
| pkg_check_modules(LIBSOLV REQUIRED libsolv>=0.7.21) | |||
There was a problem hiding this comment.
I do not recommend to lower a minimal version. It might happen that other recently introduced feature requires newer version then libsolv>=0.7.21 but at the time of introducing it the minimal require was libsolv>=0.7.25. Are you sure that this scenario is not applicable for this case?
There was a problem hiding this comment.
I am not 100% sure, I have dropped the change.
…actions" This reverts commit 2d9df1c.
kontura
force-pushed
the
revert_focus_best
branch
from
2e94e29 to
f15fbea
Compare
|
LGTM |
|
Here is a PR with ci tests update: rpm-software-management/ci-dnf-stack#1441 |
3ca5cf3
This reverts commit 2d9df1c.
The current behavior of
SOLVER_FLAG_FOCUS_BESTturned out not be viable at this time, more details in: #1106Depending on openSUSE/libsolv#549 we can either make the
SOLVER_FLAG_FOCUS_BESTfunctionality configurable with a new option or use some different approach.Closes #1106