Skip to content

Commit

Permalink
Default changelog limit restored for --compatibility
Browse files Browse the repository at this point in the history
Defaulting to keeping all changelogs, while accurate to the behavior of
legacy createrepo, can result in terrible behaviors for some
repositories, making them potentially too large to be usable (libsolv
may segfault, I'm not sure about YUM, but both end up unpacking the
data on the root partition potentially causing it to run out of space).

This behavior of the --compatibility flag was never explicitly documented.

closes #318
  • Loading branch information
dralley authored and kontura committed Jan 4, 2024
1 parent 60f245b commit 113813f
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions src/createrepo_c.c
Original file line number Diff line number Diff line change
Expand Up @@ -1450,11 +1450,7 @@ main(int argc, char **argv)
user_data.fil_zck = fil_cr_zck;
user_data.fex_zck = fex_cr_zck;
user_data.oth_zck = oth_cr_zck;
if (cmd_options->compatibility && cmd_options->changelog_limit == DEFAULT_CHANGELOG_LIMIT ) {
user_data.changelog_limit = -1;
} else {
user_data.changelog_limit = cmd_options->changelog_limit;
}
user_data.changelog_limit = cmd_options->changelog_limit;
user_data.location_base = cmd_options->location_base;
user_data.checksum_type_str = cr_checksum_name_str(cmd_options->checksum_type);
user_data.checksum_type = cmd_options->checksum_type;
Expand Down

0 comments on commit 113813f

Please sign in to comment.