Add test for dnf-automatic with non-existing config file #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
reviewed
Oct 22, 2024
Comment on lines
4
to
10
| Background: | ||
| Given I delete file "/etc/yum.repos.d/*.repo" with globs | ||
| And I create file "/etc/dnf/dnf.conf" with | ||
| """ | ||
| [main] | ||
| plugins=0 | ||
| """ |
There was a problem hiding this comment.
I think this is not needed here but I am fine with keeping it.
Could you add a comment or name the background (Backgroud: setup clean environment) to make its purpose clear?
There was a problem hiding this comment.
Right. It's a copy paste from another automatic test, but it's not needed here. I'll remove the background section. It doesn't even need to be run outside of the installroot.
m-blaha
force-pushed
the
mblaha/automatic-config
branch
from
1ace870
to
d9bf4d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.redhat.com/browse/RHEL-46030
Requires: rpm-software-management/dnf#2146