add stream transactions protobuf #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs #184 |
anjor
force-pushed
the
anjor/stream-transactions
branch
from
8640e47 to
60bbd95
Compare
anjor
force-pushed
the
anjor/stream-transactions
branch
2 times, most recently
from
9e05898 to
85ab500
Compare
anjor
force-pushed
the
anjor/stream-transactions
branch
from
85ab500 to
85b6d2c
Compare
linuskendall
reviewed
Dec 4, 2024
|
Upstream PR: gagliardetto/solana-go#267 |
|
|
||
| // Check instruction count (condition 3) | ||
| instructions := tx.Message.Instructions | ||
| if len(instructions) != 1 { |
There was a problem hiding this comment.
can vote transactions also include compute budget? is that something validators do?
There was a problem hiding this comment.
I don't think I understand Solana data well enough to answer this question. @linuskendall do you know?
gagliardetto
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The streamTransactions part of #173