forked from Block-Logic/ping-thing-client
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several refactoring suggestions for the @solana/[email protected] implementation
#10
Open
steveluscher
wants to merge
18
commits into
rpcpool:main
Choose a base branch
from
steveluscher:web-3-new-suggestions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
660d590
Force all package resolutions to suitable canary release
steveluscher 646d1e6
Make the RPC global to the application
steveluscher bdac4b9
Repair missing import of `isSolanaError`
steveluscher 5a7cb98
Implement a blockhash fetcher as an AsyncIterator
steveluscher 5c80154
Implement a slot fetcher as an AsyncIterator
steveluscher c3c9aed
Use `TransactionSigner#address` instead of computing the address from…
steveluscher 13e34ce
Only create the base transaction once
steveluscher a94ee1c
Use signers API
steveluscher 83fe4c0
Hoist factory creation up to global scope
steveluscher 4e627bd
Replace transaction send-and-confirm with default implementation
steveluscher bd1e906
Sprinking dotenv configs where they need to go
steveluscher e425521
Move the stopwatch starter _after_ the slot fetcher
steveluscher c5e69b3
JSON.stringify no longer fatals when it encounters a `bigint`
steveluscher 9d72a30
Keep the entire list of blockhashes in memory, and vend the latest _u…
steveluscher d00892b
Start exactly _one_ transaction confirmer, and a separate send retry …
steveluscher f98870b
Fetch the next slot by watching the trailing edge (completed) instead…
steveluscher e8d53b4
Prevent uncaught errors in the send-retry loop from bubbling up uncaught
steveluscher 4acf40b
Fail the transaction loop when the blockhash expires
steveluscher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "editor.defaultFormatter": "vscode.typescript-language-features" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This presumes that you're using
npm.