When searching for fungible-asset using searchAssets for particular owner_address, empty owner field in the response bug fixed #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ets, owner feild coming out to be empty bug fixed
AhzamAkhtar
changed the title
kespinola
requested changes
Dec 30, 2024
Comment on lines
+321
to
+324
| let token_account_data: Vec<token_accounts::Model> = token_accounts::Entity::find() | ||
| .filter(token_accounts::Column::Mint.is_in(asset_ids)) | ||
| .all(conn) | ||
| .await?; |
There was a problem hiding this comment.
Mints don't have owners they have mint authority so owner doesn't make sense on fungible assets. I think we should just keep this as null.
There was a problem hiding this comment.
Well this idea was inspired from helius, as in place of owner they also show the owner of the token-account for that corresponding fungible-asset which is being searched using searchAsset or getAssetByOwner for a given owner_address.
But happy to close this one.
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description