Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Token Type Filter in search_assets fuction #186

Open
wants to merge 12 commits into
base: das-38-rebase-stale-te-branch
Choose a base branch
from
Open

Added Token Type Filter in search_assets fuction #186

wants to merge 12 commits into from

Conversation

AhzamAkhtar
Copy link
Collaborator

@AhzamAkhtar AhzamAkhtar commented Dec 18, 2024 •
edited
Loading

  1. Types of filters that are added in search_assets function are
  • Fungible
  • NonFungible
  • Compressed
  • Nft
  • All
  1. Search_asset rpc call skipping fungible_assets bug fixed
  2. Not able to search for fungible asset using specific owner_address in search_asset bug fixed
  3. Added validation errors and fixed search_assets compatibility issues
  • owner_type and token_type parameter can't be use together
  • In search_assets, SearchAssetQuery doesn't support interface fixed.
  • token_type filter should only be used using owner_address
  • token_type filter can't be used with interface
  1. Tests

@AhzamAkhtar AhzamAkhtar changed the title Das 51 search asset token type filter Added Token Type Filter in search_assets fuction Dec 18, 2024
@AhzamAkhtar AhzamAkhtar marked this pull request as draft December 23, 2024 12:12
@AhzamAkhtar AhzamAkhtar force-pushed the das-51-search-asset-token-type-filter branch from d6b96d7 to bfe1fe0 Compare December 27, 2024 11:27
@AhzamAkhtar AhzamAkhtar force-pushed the das-51-search-asset-token-type-filter branch from bfe1fe0 to e1ad545 Compare December 27, 2024 11:42
@AhzamAkhtar AhzamAkhtar marked this pull request as ready for review December 27, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AhzamAkhtar