Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this build workflow lies a bit - it tells CMake we are building with GCC (
-DTOOLCHAIN=gcc
), but actually on macOS by defaultgcc
is a wrapper for AppleClang. I did it this way because it was the simplest way to get it to work. Passing-DTOOLCHAIN=clang
fails with a bunch of errors due to clang not liking the parameters that CMake is passing.