Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close pipes when dropping them, check for closed pipe when flushing a writer #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maxbrunsfeld
Copy link

Thanks for sharing this library! This PR makes two semi-orthogonal improvements:

  1. When attempting to flush a closed PipeWriter, return an error immediately. This makes flush consistent with write, and it avoids an indefinite hang that you would otherwise get when attempting to flush a closed pipe.
  2. Mark a pipe as closed when either the PipeWriter or PipeReader are dropped. Previously, when one end of a pipe was dropped, any read/writes to the other end would hang indefinitely, which does not seem like it would ever be a useful behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant