Close pipes when dropping them, check for closed pipe when flushing a writer #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for sharing this library! This PR makes two semi-orthogonal improvements:
flush
a closedPipeWriter
, return an error immediately. This makesflush
consistent withwrite
, and it avoids an indefinite hang that you would otherwise get when attempting to flush a closed pipe.PipeWriter
orPipeReader
are dropped. Previously, when one end of a pipe was dropped, any read/writes to the other end would hang indefinitely, which does not seem like it would ever be a useful behavior.