Render each mime-part into an individual iframe #9787
+478
−305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabzm
force-pushed
the
message-render-iframe
branch
4 times, most recently
from
4fd3901 to
2a397fe
Compare
pabzm
force-pushed
the
message-render-iframe
branch
from
2a397fe to
44b0165
Compare
pabzm
changed the title
This probably wasn't implemented previously because HTML-parts usually didn't run through get.php.
This includes a new "message loading" notice without meta refresh (which requires unsafe-inline in a CSP, which we want to avoid)
We need the information in the browser, because the remote-objects-message is now rendered independently from the message contents, and we need it for each message part.
pabzm
force-pushed
the
message-render-iframe
branch
from
44b0165 to
acf3126
Compare
The calling code replaced the $rcmail->output on the fly, which makes is hardly testable. Also that class was used only in the class `rcmail_action_mail_get`, and it's a pretty thin layer on top of `rcmail_output_html`, which is not necessary.
pabzm
force-pushed
the
message-render-iframe
branch
from
acf3126 to
dbabc7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing #9465
A new clean restart over the previous pull request.
TODO: