CMakeLists improvements #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype-gl_BUILD_MAKEFONT is false.
When generating solution by multiple configure, then generate combo instead of single configure, generate combo or generate alone, _USE_MATH_DEFINES preprocessor definition is not populated. Alternative solution is to add unset(HAVE_M_PI CACHE) in the else block just after add_definitions(-D_USE_MATH_DEFINES), but the proposed way avoids unnecessary checks each time the project is configured.
rougier
reviewed
Apr 19, 2017
| @@ -32,6 +32,13 @@ option(freetype-gl_BUILD_HARFBUZZ "Build the freetype-gl harfbuzz support (exper | |||
| option(freetype-gl_BUILD_MAKEFONT "Build the makefont tool" ON) | |||
| option(freetype-gl_BUILD_TESTS "Build the tests" ON) | |||
There was a problem hiding this comment.
Maybe this should be OFF by default
There was a problem hiding this comment.
Yes, it could be. And installing ImageMagick should satisfy Jarvis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.