Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update alert view to use data generation #300

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

kelsos
Copy link
Member

@kelsos kelsos commented Oct 30, 2024

Closes #(issue_number)

@kelsos kelsos requested a review from a team as a code owner October 30, 2024 09:23
There is flakiness in the first test caused by
a mouseover event to the wrong button.
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.97%. Comparing base (243d0d7) to head (6a7d1d0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   84.97%   84.97%           
=======================================
  Files         115      115           
  Lines       10388    10388           
  Branches     1271     1271           
=======================================
  Hits         8827     8827           
  Misses       1561     1561           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelsos kelsos merged commit 6a7d1d0 into rotki:main Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants