Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #277

Merged
merged 3 commits into from
Oct 4, 2024
Merged

chore: update dependencies #277

merged 3 commits into from
Oct 4, 2024

Conversation

kelsos
Copy link
Member

@kelsos kelsos commented Sep 26, 2024

Closes #(issue_number)

@kelsos kelsos requested a review from a team as a code owner September 26, 2024 10:12
@kelsos kelsos changed the base branch from deps to main September 26, 2024 10:13
Copy link
Contributor

@lukicenturi lukicenturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kelsos kelsos marked this pull request as draft September 27, 2024 09:31
@kelsos kelsos force-pushed the deps branch 2 times, most recently from b1e0e09 to b12b9a8 Compare October 4, 2024 11:53
@kelsos kelsos marked this pull request as ready for review October 4, 2024 11:57
Check open storybook issue 24238 about generics not working
with vue and storybook.
Copy link

@cleanerzkp cleanerzkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.94%. Comparing base (1667062) to head (acb955f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   84.94%   84.94%           
=======================================
  Files         115      115           
  Lines       10348    10348           
  Branches     1268     1268           
=======================================
  Hits         8790     8790           
  Misses       1558     1558           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelsos kelsos merged commit b884c00 into rotki:main Oct 4, 2024
5 checks passed
@kelsos kelsos deleted the deps branch October 4, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants