Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor modifications on the recommended structure #8

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Minor modifications on the recommended structure #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aef4c24
fix: make sure that rule level is string
kelsos Jan 11, 2024
63be1f6
chore: release v0.0.3
kelsos Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions docs/rules/no-deprecated-classes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: '@rotki/no-deprecated-classes'
description: disallow the usage of vuetify css classes since they are replaced with tailwindcss
since: 0.1.0
since: 0.0.1
---

# @rotki/no-deprecated-classes
Expand All @@ -19,22 +19,22 @@ This rule reports usages of deprecated css classes in the code.

```vue
<!-- ✓ GOOD -->
<template><div class="flex flex-col"/></template>
<template><div class="flex flex-col" /></template>

<template><div class="block"/></template>
<template><div class="block" /></template>

<template><div class="grow"/></template>
<template><div class="grow" /></template>

<template><div class="justify-between"/></template>
<template><div class="justify-between" /></template>

<!-- ✗ BAD -->
<template><div class="d-flex flex-column"/></template>
<template><div class="d-flex flex-column" /></template>

<template><div class="d-block"/></template>
<template><div class="d-block" /></template>

<template><div class="grow"/></template>
<template><div class="grow" /></template>

<template><div class="justify-space-between"/></template>
<template><div class="justify-space-between" /></template>
```

</eslint-code-block>
Expand All @@ -49,7 +49,7 @@ This rule reports usages of deprecated css classes in the code.

## :rocket: Version

This rule was introduced in @rotki/eslint-plugin v0.1.0
This rule was introduced in @rotki/eslint-plugin v0.0.1

## :mag: Implementation

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@rotki/eslint-plugin",
"version": "0.0.2",
"version": "0.0.3",
"packageManager": "[email protected]",
"type": "commonjs",
"license": "AGPL-3.0",
Expand Down
4 changes: 2 additions & 2 deletions scripts/update-recommended-rules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ async function main() {
export = {
extends: [require.resolve('./base')],
parserOptions: {
ecmaVersion: 2018,
ecmaVersion: 2022,
sourceType: 'module',
ecmaFeatures: {
jsx: true
Expand All @@ -30,7 +30,7 @@ export = {
rules: {
${rules
.filter((rule) => rule.recommended)
.map((rule) => `'${rule.id}': 'warn',`)
.map((rule) => `'${rule.id}': 'warn' as const,`)
.join('\n ')}
},
}`,
Expand Down
4 changes: 2 additions & 2 deletions src/configs/recommended.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
export = {
extends: [require.resolve('./base')],
parserOptions: {
ecmaVersion: 2018,
ecmaVersion: 2022,
sourceType: 'module',
ecmaFeatures: {
jsx: true,
Expand All @@ -13,6 +13,6 @@ export = {
es6: true,
},
rules: {
'@rotki/no-deprecated-classes': 'warn',
'@rotki/no-deprecated-classes': 'warn' as const,
},
};