Add the EVM tokens for 1.33.0 that are in zksync lite bridge #133
Conversation
Added in the global DB itself here: rotki/rotki#3985
LefterisJP
force-pushed
the
1_33_zksync_lite_bridge_assets
branch
from
108d563
to
95f9ac3
Compare
Signed-off-by: Lefteris Karapetsas <[email protected]>
LefterisJP
force-pushed
the
1_33_zksync_lite_bridge_assets
branch
from
be02417
to
a3b19d5
Compare
| "assets_re": re.compile(r'.*INSERT +INTO +assets\( *identifier *, *type *, *name *, *symbol *, *started *, *swapped_for *, *coingecko *, *cryptocompare *, *details_reference *\) +VALUES\((.*?),(.*?),(.*?),(.*?),(.*?),(.*?),(.*?),(.*?),(.*?)\).*?'), | ||
| "ethereum_tokens_re": re.compile(r'.*INSERT +INTO +ethereum_tokens\( *address *, *decimals *, *protocol *\) +VALUES\((.*?),(.*?),(.*?)\).*'), | ||
| "common_asset_details_re": re.compile(r'.*INSERT +INTO +common_asset_details\( *asset_id *, *forked *\) +VALUES\((.*?),(.*?)\).*') | ||
| "assets_re": re.compile(r'.*INSERT +INTO +assets\( *identifier *, *type *, *name *, *symbol *, *started *, *swapped_for *, *coingecko *, *cryptocompare *, *details_reference *\) *VALUES\((.*?),(.*?),(.*?),(.*?),(.*?),(.*?),(.*?),(.*?),(.*?)\).*?'), |
There was a problem hiding this comment.
All these *\) *VA are since ) and VALUES can be without a space.
There was a problem hiding this comment.
Does this match what we have in the main repo? Regarding the spaces and if the query is the same
| "assets_re": re.compile(r'.*INSERT +INTO +assets\( *identifier *, *name *, *type *\) *VALUES\(([^,]*?),([^,]*?),([^,]*?)\).*?'), |
There was a problem hiding this comment.
Group is everything but comma now since before it was failing for strings that had parentheses in them. Like what this PR adds for a name of a token: 'Diversified Staked ETH Index (dsETH)'
There was a problem hiding this comment.
Have you tested if the parser in the repo handles this?
There was a problem hiding this comment.
Which parser? There is a CI test that failed in this repo. This is why I adjusted this.
There was a problem hiding this comment.
This regular expressions that we have in the main repo https://github.com/rotki/rotki/blob/655631850fed261c59037c23dd12a0dcf8111fb6/rotkehlchen/globaldb/updates.py#L123
There was a problem hiding this comment.
Added it here: rotki/rotki#7549
Signed-off-by: Lefteris Karapetsas <[email protected]>
To be able to work with the changes here: rotki/assets#133 Essentially to: 1. Handle "(" inside a string 2. Handle no space between ) and VALUES Signed-off-by: Lefteris Karapetsas <[email protected]>
|
I also added tests for the collections and the collection mappings regexes in this repo |
To be able to work with the changes here: rotki/assets#133 Essentially to: 1. Handle "(" inside a string 2. Handle no space between ) and VALUES Signed-off-by: Lefteris Karapetsas <[email protected]>
Added in the global DB itself here: rotki/rotki#3985