Restore peg example, turn into an actual parser #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts commit 7fb35c5.
Turn the example into a valid benchmark by actually implementing a parser, instead of only (badly) validating the JSON. Unicode escape handling is still on the simplistic side, but it shouldn't be worse than some of the other examples.
|
For reference, removed in 7fb35c5 Peg has a sufficient number of downloads to be included.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was interested in a benchmark for the peg crate, so I restored the example and implemented the actual parsing. The result is quite nice: On my machine it's only ~10% slower than winnow, and I find peg's grammars much easier to read than many of the alternatives.