Fix issue with high-frequency messages #950
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…process whole message queue of each subscriber
|
HI @ivanpauno and @roger-strain, do you have opinion about this ? the contributor asked for your feedback. |
|
In all honesty, the changes and discussion around this were so long ago that I'm not in that headspace anymore, so I'm not sure I can contribute any valuable feedback at this point, especially within the context of rviz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with frequent messages. As far as I understand,
spin_someonly processes the oldest messages in the queue. So when a message for a particular subscriber arrives more frequently than the update rate of rviz, then the queue gets longer and longer. See ros2/rclcpp#1156 for comparison betweenspin_someandspin_all.I am not sure whether
spin_allintroduces disadvantages in some cases compared tospin_some...Maybe @ivanpauno and @roger-strain have some opinions on this, as they proposed ros2/rclcpp#1156.